fix(cli): publish: Fix panic + Make waiting for build results more modular #4410
+118
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
changed the title
syrusakbary
approved these changes
Jan 25, 2024
|
Have you considered making it, so users can do |
|
@ayys I actually did, sadly that's a bit of a pain with |
theduke
force-pushed
the
cli-publish-wait-improvements
branch
2 times, most recently
from
0fdd68b to
feb4ee4
Compare
…odular * Fixes a panic due to nested tokio runtimes * Exposes a --wait flag, which only waits for the container, and a --wait-all flag, which also waits for bindings and native executables.
theduke
force-pushed
the
cli-publish-wait-improvements
branch
from
feb4ee4 to
7055657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a panic due to nested tokio runtimes
Exposes a --wait flag, which only waits for the container, and a
--wait-all flag, which also waits for bindings and native executables.
Also adds a timeout for waiting.